feat(metrics): update max user-defined dimensions from 9 to 29 #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrodamascena
requested review from
rubenfonseca
and removed request for
a team
pull-request-size
bot
added
the
size/S
heitorlessa
reviewed
Aug 5, 2022
tests/functional/test_metrics.py
Outdated
| # GIVEN we have more dimensions than CloudWatch supports | ||
| dimensions = [{"name": f"test_{i}", "value": "test"} for i in range(11)] | ||
| # GIVEN we have more dimensions than CloudWatch supports (N+1) | ||
| dimensions = [{"name": f"test_{i}", "value": "test"} for i in range(31)] |
There was a problem hiding this comment.
perhaps, let's start using the constant MAX_DIMENSIONS so these can be updated/failed accordingly?
Codecov Report
@@ Coverage Diff @@
## develop #1417 +/- ##
========================================
Coverage 99.89% 99.89%
========================================
Files 119 121 +2
Lines 5456 5480 +24
Branches 624 627 +3
========================================
+ Hits 5450 5474 +24
Misses 2 2
Partials 4 4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…changes in future
heitorlessa
changed the title
heitorlessa
changed the title
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
boring-cyborg
bot
added
the
documentation
heitorlessa
approved these changes
Aug 5, 2022
|
thanks a lot @leandrodamascena !! I've updated the documentation to reflect the new dimension limit, and reverted the test to be N+1 instead of N+2 (both works) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1413
Summary
Changes
Amazon added support to up 30 dimensions per metric. In this PR we increase this limit
User experience
Before: User could add up to 10 dimensions per user defined metric
After: User can add up to 30 dimensions per user defined metric.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.